-
Couldn't load subscription status.
- Fork 158
fix: CI pipeline issue fix #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* CI Pipeline fix for Client Advisor * added tags in CAdeploy.yml file * add my feature branch * tags changes updated in CAdeploy.yml file * added template name condition based * removed my feature branch from pipeline * Additional Troubleshooting steps
… bice… (#678) * Remove createdby from pipeline and add change Createdby logic in bicep file * Add 'createdBy' parameter to Azure deployment * Add 'createdBy' parameter for tagging
Co-authored-by: Copilot <[email protected]>
feat: Create Separate User Assigned Identity for SQL DB with Specified Access
…emoved the unsued params (#690) * fix: Dev to main (#681) * fix: added tags in CAdeploy.yml file (#675) * CI Pipeline fix for Client Advisor * added tags in CAdeploy.yml file * add my feature branch * tags changes updated in CAdeploy.yml file * added template name condition based * removed my feature branch from pipeline * Additional Troubleshooting steps * fix: Remove createdby from pipeline and add change Createdby logic in bice… (#678) * Remove createdby from pipeline and add change Createdby logic in bicep file * Add 'createdBy' parameter to Azure deployment * Add 'createdBy' parameter for tagging * added new 'type' tag (#682) * Update docs/TroubleShootingSteps.md Co-authored-by: Copilot <[email protected]> * Update GitHub Issues link in troubleshooting steps --------- Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]> * fix: Removed commented params * Update README and azure.yml for minimum azd version 1.18.0 --------- Co-authored-by: NirajC-Microsoft <[email protected]> Co-authored-by: VishalS-Microsoft <[email protected]> Co-authored-by: Harsh-Microsoft <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Prajwal D C <[email protected]>
Disable the use of Dev Container for Azure template validation.
fix: Cross subscription issue while running post deployments scrip
* ci: Update environment variable assignments for SQL client IDs and names in deploy wf * Remove redundant branch from deployment triggers
feat: Down merge from dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
🎉 This PR is included in version 1.9.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Purpose
This pull request makes a minor update to the workflow configuration in
.github/workflows/CAdeploy.ymlto ensure the correct managed identity values are used for SQL resources instead of web application resources.CLIENT_IDandCLIENT_NAMEenvironment variables to use SQL managed identity values (managedidentitY_SQL_CLIENTIDandmanagedidentitY_SQL_NAME) instead of the previous web app managed identity fields.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information